Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21230] Migrate Discovery Server CI to Github (backport #90) #91

Merged
merged 1 commit into from
Jul 2, 2024
Merged

[21230] Migrate Discovery Server CI to Github (backport #90) #91

merged 1 commit into from
Jul 2, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jul 1, 2024 •
edited by JesusPoderoso
Loading

Description

This PR improves the GitHub CI of this repo, to make it as similar as the one in Fast DDS

Note: While backporting this PR, please ensure the following changes:

  • Remove nightly jobs
  • Update ubuntu-ci.yml file with the proper fallback tag
  • Change fastdds.repos to fastrtps.repos
  • Fast DDS 2.6.x requires building on ubuntu-20.04

@Mergifyio backport 1.2.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The added tests pass locally.
  • N/A Changes are backwards compatible.
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
This is an automatic backport of pull request #90 done by [Mergify](https://mergify.com).

@mergify mergify bot added the conflicts label Jul 1, 2024
@mergify Mergify
Copy link
Author

mergify bot commented Jul 1, 2024

Cherry-pick of c323886 has failed:

On branch mergify/bp/1.2.x/pr-90
Your branch is up to date with 'origin/1.2.x'.

You are currently cherry-picking commit c323886.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   .github/workflows/config/build.meta
	new file:   .github/workflows/config/test.meta
	new file:   .github/workflows/config/test.repos
	new file:   .github/workflows/nightly-ubuntu-ci.yml
	new file:   .github/workflows/reusable-ubuntu-ci.yml
	new file:   .github/workflows/ubuntu-ci.yml
	new file:   RELEASE_SUPPORT.md

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   .github/pull_request_template.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Jul 1, 2024
Merged
5 tasks
@JesusPoderoso JesusPoderoso added this to the v1.2.3 milestone Jul 1, 2024
@JesusPoderoso JesusPoderoso self-requested a review July 1, 2024 15:13
@JesusPoderoso JesusPoderoso requested review from JesusPoderoso and removed request for JesusPoderoso July 1, 2024 15:14
JesusPoderoso
JesusPoderoso approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@JesusPoderoso
Migrate Discovery Server CI to Github (#90)
61ae162 
* Refs #21230: Migrate Discovery Server CI to Github

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #21230: Add RELEASE_SUPPORT.md file

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #21230: Add missing flaxy test arg

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #21230:  Introduce improvements from similar PR reviews

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #21230: Apply rev suggestions

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #21230: Add missing CI checks in PR template

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit c323886)
@JesusPoderoso JesusPoderoso self-requested a review July 2, 2024 08:54
@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending labels Jul 2, 2024
@JesusPoderoso JesusPoderoso merged commit e712b3b into 1.2.x Jul 2, 2024
4 checks passed
@JesusPoderoso JesusPoderoso deleted the mergify/bp/1.2.x/pr-90 branch July 2, 2024 10:18
JesusPoderoso added a commit that referenced this pull request Jul 24, 2024
@mergify @JesusPoderoso
Migrate Discovery Server CI to Github (#90) (#91)
af53dd2 
* Refs #21230: Migrate Discovery Server CI to Github

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #21230: Add RELEASE_SUPPORT.md file

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #21230: Add missing flaxy test arg

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #21230:  Introduce improvements from similar PR reviews

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #21230: Apply rev suggestions

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #21230: Add missing CI checks in PR template

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit c323886)

Co-authored-by: Jesús Poderoso <[email protected]>
JesusPoderoso added a commit that referenced this pull request Jul 24, 2024
@mergify @JesusPoderoso
Migrate Discovery Server CI to Github (#90) (#91)
91a1981 
* Refs #21230: Migrate Discovery Server CI to Github

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #21230: Add RELEASE_SUPPORT.md file

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #21230: Add missing flaxy test arg

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #21230:  Introduce improvements from similar PR reviews

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #21230: Apply rev suggestions

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #21230: Add missing CI checks in PR template

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit c323886)

Co-authored-by: Jesús Poderoso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v1.2.3
Development

Successfully merging this pull request may close these issues.
1 participant
@JesusPoderoso